Oliver Bertuch (Aug 17 2023 at 11:33): Oliver Bertuch (Aug 17 2023 at 11:33):Should we have a nice report for the test runs on Github Actions? https://github.com/marketplace/actions/test-reporter or https://github.com/marketplace/actions/junit-report-action provides a ready to use action step for this
Philip Durbin 🚀 (Aug 17 2023 at 11:37):Yes, yes please!
Oliver Bertuch (Aug 17 2023 at 11:38):Maybe I can make that part of my JUnit 5 transition PR?
Oliver Bertuch (Aug 17 2023 at 11:38):(Which is underway BTW)
Philip Durbin 🚀 (Aug 17 2023 at 11:39):Sure or shall we create a smoke test PR (and issue) and put the reports there?
Oliver Bertuch (Aug 17 2023 at 11:39):More tweaks necessary than I expected. Didn't have on my radar we'd have so many parameterized tests in JUnit4. The swiss folks were busy! And yet again I see why I prefer JUnit 5 to write those... Just so much more convenient!
Oliver Bertuch (Aug 17 2023 at 11:40):Technically the unit tests have their own results which are not dependent on a smoke test. So I'd rather publish them as part of this testing.
Philip Durbin 🚀 (Aug 17 2023 at 11:42):Sounds good. That's how it used to be when I had chained Jenkins jobs set up. Only if the unit tests passed would it even advance to API tests. When all is passing you can see separate reports.
Philip Durbin 🚀 (Aug 17 2023 at 11:43):(I'll start a new topic someday about combined code coverage.)
Oliver Bertuch (Aug 17 2023 at 11:43):In my PR for OIDC I introduce real integration tests for the first time
Oliver Bertuch (Aug 17 2023 at 11:43):haha I was about to go there :smile_cat:
Oliver Bertuch (Aug 17 2023 at 11:43):I'll stop blabbering now... :shush:
Oliver Bertuch (Sep 14 2023 at 12:46):I just finished updating https://github.com/IQSS/dataverse/pull/9273 with latest develop. Extended docs on integration testing as well. JaCoCo working smoothless now :partying_face: @Philip Durbin should we address the reporting thing in this one?
Philip Durbin 🚀 (Sep 14 2023 at 13:05):Sure!
Philip Durbin 🚀 (Sep 18 2023 at 16:07):I created this related issue: Let contributors know why tests are failing #9916
Philip Durbin 🚀 (Sep 18 2023 at 21:13):Here's an example of MoveIT failing: https://jenkins.dataverse.org/job/IQSS-Dataverse-Develop-PR/view/change-requests/job/PR-9925/2/testReport/
Philip Durbin 🚀 (Sep 18 2023 at 21:14):Screen-Shot-2023-09-18-at-5.13.52-PM.png
Oliver Bertuch (Sep 18 2023 at 21:28):Do we want reports always() or just on failure() @Philip Durbin ?
Philip Durbin 🚀 (Sep 18 2023 at 22:15):Hmm, can we please try always?
Oliver Bertuch (Sep 18 2023 at 22:24):First progress: https://github.com/IQSS/dataverse/actions/runs/6228536081 shows an artifact with results from unit + integration testing
Oliver Bertuch (Sep 18 2023 at 22:24):(not API!)
Philip Durbin 🚀 (Sep 18 2023 at 22:47):Great but from a private/incognito window I can't download the artifacts.
Philip Durbin 🚀 (Sep 18 2023 at 23:38):"The Actions API has just been released, and this can be used to retrieve an artifact download URL.
See https://developer.github.com/v3/actions/artifacts/ "
-- https://github.com/actions/upload-artifact/issues/27#issuecomment-578937784
Philip Durbin 🚀 (Sep 19 2023 at 00:20):Here, try this: https://nightly.link/IQSS/dataverse/workflows/maven_tests/9916-action-reports/junit-test-results.zip
Via Artifact download URL only work for registered users (404 for guests) #51 at https://github.com/actions/upload-artifact/issues/51
Philip Durbin 🚀 (Sep 19 2023 at 00:29):Just leaving this compare link to see the recent commits: https://github.com/poikilotherm/dataverse/compare/9268-mpconfig-oidc-provider...IQSS:dataverse:9916-action-reports
Oliver Bertuch (Sep 19 2023 at 06:19):No no no, the point is that these reports can be used from another workflow in the repo context, which has write access to the run. Otherwise runs from forks will not have reports.
Oliver Bertuch (Sep 19 2023 at 06:19):But I almost fell asleep before my keyboard, so I had to take a break after this step
Philip Durbin 🚀 (Sep 19 2023 at 10:30):Ok, but you have to admit that nightly.link is a neat hack. :big_smile:
Oliver Bertuch (Sep 19 2023 at 11:30):Oh yes it is :-D
Last updated: Nov 01 2025 at 14:11 UTC