Stream: dev

Topic: dataverse-previewers external resources

Loïc (Mar 13 2024 at 13:34):

Hello, While updating the previewers for dataverse.no, we realized that the current version of the Dataverse previewers was making various calls to external URLs for the resources needed.
@Benedikt fixed all of this to meet the needs of our Dataverse instance. He also made a pull request to the GDCC repository so everyone can benefit.

We have not received much feedback on this. Does anyone have any suggestions or comments on this?
https://github.com/gdcc/dataverse-previewers/pull/52

Philip Durbin 🚀 (Mar 13 2024 at 13:45):

I noticed and gave it an :eyes: but I thought I'd wait for Jim Myers to weigh in.

By calling out to external URLs, the previewer code is smaller. There are trade offs, basically.

Maybe in the PR you could write a bit more about why, about what your concerns are.

Benedikt (Mar 13 2024 at 14:07):

In some places, reference was made to the following servers:
https://ajax.googleapis.com/ajax/libs/jquery/3.5.1
https://stackpath.bootstrapcdn.com/bootstrap/3.4.1
https://cdnjs.cloudflare.com/ajax/libs/jquery-zoom/1.7.21
https://cdn.jsdelivr.net/handsontable/0.28.4
https://unpkg.com/georaster@1.6.0

It is debatable whether it is good or bad. But I thought these points when I saw it.

• Independent from other servers
• Can be used completely locally
• Privacy and security (you don't have to trust another service to return the right code.)
• If you e.g. block a google, then you can't use this site.

This line was called twice in succession. Which is not necessary. (Probably because it was at the end of the other line and it was overlooked.)
<link type="text/css" rel="stylesheet" href="/dataverse-previewers/previewers/css/preview.css"/>

The footnote has also been adjusted slightly. This makes it clear where to find the current repo.

Philip Durbin 🚀 (Mar 13 2024 at 14:11):

Thanks for all the details and for putting them in the PR! :heart:

Benedikt (Mar 13 2024 at 14:15):

We also have an image of the version running. If you want to test it. https://dataverseno.github.io/dataverse-previewers/previewers/v1.4/AudioPreview.html
https://dataverseno.github.io/dataverse-previewers/previewers/v1.4/TextPreview.html

Philip Durbin 🚀 (Mar 13 2024 at 14:16):

nice

Last updated: Nov 01 2025 at 14:11 UTC