@Oliver Bertuch thanks for PR #11654 where you're improving how database settings are handled and for explaining it during tech hours yesterday!
I picked it up for review and I'm thinking I'd like to see Jenkins successfully running the API test suite. @Don Sizemore how do you feel about an extra Jenkins job pointed at that branch and an upcoming ansible branch specifically? We've done this for Payara upgrades in the past.
@Oliver Bertuch have you created an issue in the ansible repo yet? If not, do you mind?
There's already a PR ready to go! https://github.com/gdcc/dataverse-ansible/pull/399
Ah! Thanks! I looked at issues but not PRs.
Am I spoiling @Don Sizemore too much? :partying_face:
Ha, you can never spoil him enough. We owe him so much. ![]()
@Oliver Bertuch I gave this PR back to you. Can you please look at https://github.com/IQSS/dataverse/pull/11654#discussion_r2263981716 ?
Also, it seems a bit disruptive. Do you still want to try to get it in 6.8 (last call for core devs is tomorrow) or should we push it to 6.9?
I'm fine with pushing it to 6.9. :wink:
Pushed! Thanks!
I also moved it from "in progress" to "on hold". Happy to chat about it whenever! I feel like it's close.
I'm just not sure if you really want to change how WorkflowsAdmin#IP_WHITELIST_KEY works or not. :grimacing:
Not the first time I'm taking out the broom to cleanup oopsies in the codebase :stuck_out_tongue_wink:
nope
@Oliver Bertuch I merged develop into #11654 for you and then moved it to "ready for QA".
@Oliver Bertuch I resolved merge conflicts for you yesterday (just in changelog.rst).
Meanwhile, @Omer M Fahim and I noticed this error:
TASK [dataverse : STORAGE | Get infos on container] ********
fatal: [localhost]: FAILED! => {"changed": false, "msg": "Error connecting: Error while fetching server API version: Not supported URL scheme http+docker"}
Any ideas? Or maybe @Don Sizemore knows? Here's the latest run, which I just left a comment about: https://jenkins.dataverse.org/job/IQSS-Dataverse-11639/22/console
Philip Durbin ๐ said:
Oliver Bertuch I resolved merge conflicts for you yesterday (just in changelog.rst).
Meanwhile, Omer M Fahim and I noticed this error:
TASK [dataverse : STORAGE | Get infos on container] ********
fatal: [localhost]: FAILED! => {"changed": false, "msg": "Error connecting: Error while fetching server API version: Not supported URL scheme http+docker"}Any ideas? Or maybe Don Sizemore knows? Here's the latest run, which I just left a comment about: https://jenkins.dataverse.org/job/IQSS-Dataverse-11639/22/console
The http+docker error should've been fixed in https://github.com/gdcc/dataverse-ansible/commit/916b3db27ded3434b84f43b456a0022afd86509d โ I'll take a look at that job and see why it's popped back up?
Oh, ok. Yes, please take a look. Thanks, Don! ![]()
#11654 has been merged! :tada:
Unfortunately, it needs a follow up
Yeah, I saw #11996
At least Jim caught it before release!
Aye
I'm looking into creating a PR to solve the problems for good
I noticed you assigned yourself. Thanks.
Also addressing the concerns of how do plugins etc define their own settings
Not sure if I should just get a small fix done (and it's not going to be very small) or do the refactoring
Both? :smile: Two PRs? And close one after getting some feedback?
It would again need a full transition and data migration as with the file formats before
@Don Sizemore https://jenkins.dataverse.org/job/IQSS-dataverse-develop/ is failing with {"message": "The name of the setting is invalid.", "status": "ERROR"}, "msg": "Status code was 400 and not [200]: HTTP Error 400: Bad Request", "redirected": false, "server": "Payara Server 6.2025.3 #badassfish", "status": 400, "url": "http://localhost:8080/api/admin/settings/BuiltinUsers.KEY",. Seems related.
Because the setting keys are once again made up very individually. Not just a matter of a simple static string
Yeah. I'm happy to jump on a zoom call with you and Jim if you want.
He probably didn't upgrade dataverse-ansible yet. The PR is ready to go in that repo, but probably wasn't merged yet
I had to step away from doing coding and fix the K8s LB...
(So need to put out :fire: :fire: :fire: first :firefighter: )
Yeah, https://github.com/gdcc/dataverse-ansible/pull/399 was merged at 4pm yesterday. I just kicked off https://jenkins.dataverse.org/job/IQSS-dataverse-develop/2306/ to see if it goes green now.
@Oliver Bertuch have you seen the comment from @Leo Andreev at https://github.com/IQSS/dataverse/pull/11654#issuecomment-3570855865 ?
Yes I did :smile:
And I did some coding this evening to take a shot at making integration tests for our data migration scripts a (non-perfect) reality. Started with a reproducer for what Leonid discovered in here: https://github.com/IQSS/dataverse/pull/12002/files#diff-187411d0ce6130f4975e28d198715bd5e9c353cf4a1bddf2e1736c1db59c480e
And I can see from this CI log that I did create a reproducer as planned.
image.png
Wonderful! Thanks!
Since I'm pretty sure we need this for 6.9, which is fast approaching code freeze, we should probably have an issue tracking it, right? I'm happy to create one.
As mentioned in my PR this will be one PR fixing both Leonids and Jims issue with patches.
I just had the urge to do this properly instead of manual testing, because I'll need it for the fix for Jim as well. (The migration needs extension)
Being able to test such changes without deploying and trying to doctor your database first is always helpful. Keep the DX lighter and raises confidence.
Great. I didn't realize you had a PR already. This one: #12002. I just gave it a milestone of 6.9 and put it under "in progress". I put it at the top of that column and will try to remember to mention it at standup. We have code freeze next Thursday. See #community > Release 6.9 Timeline
"next Thursday" = 2025-12-04, aye?
Yes, exactly.
I already have the fix for the migration (it's a complicated postgres index thing...) in the branch.
Do you think when fixing the #11996 bits I should just extend the data migrations in V6.8.0.1 or should it create a V6.8.0.3 for it?
(V6.8.0.1 should have been rolled back for anyone who has the setting, so there shouldn't be a conflict in these cases)
Woof. Not sure. @Leo Andreev, what do you think?
@Oliver Bertuch it might be easier to ask in Slack, in #dv-tech
Bah. No one likes Slack. :grimacing: </ :iron: y>
Ha, no kidding.
Last updated: Jan 09 2026 at 14:18 UTC