Unique code / standard code · dev

Stream: dev

Topic: Unique code / standard code

Benedikt (May 08 2024 at 12:16):

i have a question about the code. sometimes SEP and sometimes File.separator are used and sometimes other codes are included. Can I change this and is there a default and preference? Otherwise I would use File.separator.

Philip Durbin 🚀 (May 08 2024 at 12:31):

Sorry, SEP? Can you please link to the code?

Benedikt (May 08 2024 at 13:29):

Yes, of course... Still wanted to have made.
https://github.com/IQSS/dataverse/blob/07eb97be160faf9ae4059bf3159e1a334382ccb4/src/main/java/edu/harvard/iq/dataverse/DatasetVersionServiceBean.java#L9
https://github.com/IQSS/dataverse/blob/07eb97be160faf9ae4059bf3159e1a334382ccb4/src/main/java/edu/harvard/iq/dataverse/api/BatchServiceBean.java#L49
https://github.com/IQSS/dataverse/blob/07eb97be160faf9ae4059bf3159e1a334382ccb4/src/main/java/edu/harvard/iq/dataverse/batch/jobs/importer/filesystem/FileRecordJobListener.java#L84

And more...

Philip Durbin 🚀 (May 08 2024 at 13:32):

Interesting. Personally, I would probably use File.separator but if you want to define it as SEP, I don't think anyone would object.

Benedikt (May 08 2024 at 13:33):

I have also found a few other things that I have been improving bit by bit. it's not bad, but make the code more readable and a bit more uniform. But I don't know if that's what you want.

Philip Durbin 🚀 (May 08 2024 at 13:33):

Well, we had a recent conversation about coding style that resulted in #10524. If you have more you think we should add to that list, please let us know!