✔ war file artifact from GitHub Actions · dev

Stream: dev

Topic: ✔ war file artifact from GitHub Actions

Philip Durbin 🚀 (Aug 17 2023 at 10:45):

If we were to use GitHub Actions to build the war file and upload it as an artifact (to GitHub Actions), where would we add it to the workflow?

In our "build with Maven" step, we do a mvn install rather than a mvn package: https://github.com/IQSS/dataverse/blob/1c356b44f5f190d5da0c2dfd3ef42590accd5db1/.github/workflows/maven_unit_test.yml#L50

Philip Durbin 🚀 (Aug 17 2023 at 10:45):

I'm interested in adding this to the Java 17 pull request, if possible.

Oliver Bertuch (Aug 17 2023 at 11:24):

The install is necessary because of the SPI module

Oliver Bertuch (Aug 17 2023 at 11:24):

It will build and install the WAR file in the local Maven repo as well

Oliver Bertuch (Aug 17 2023 at 11:25):

Do you want to have the WAR as an artifact independent of any integration tests running?

Oliver Bertuch (Aug 17 2023 at 11:25):

(Or maybe even use it externally to feed an integration test?)

Oliver Bertuch (Aug 17 2023 at 11:26):

If it should be uploaded after unit tests but before integration tests, that step needs to be in the maven_unit_test.yml workflow

Oliver Bertuch (Aug 17 2023 at 11:26):

Otherwise in container_app_push.yml

Oliver Bertuch (Aug 17 2023 at 11:27):

You probably see this line here: https://github.com/poikilotherm/dataverse/blob/1c356b44f5f190d5da0c2dfd3ef42590accd5db1/.github/workflows/maven_unit_test.yml#L70-L70

Oliver Bertuch (Aug 17 2023 at 11:27):

That's were I delete the WAR file from the local Maven repo so it won't be infecting the cache

Oliver Bertuch (Aug 17 2023 at 11:28):

Uploading an artifact should happen just before that step

Philip Durbin 🚀 (Aug 17 2023 at 11:29):

I did notice that "We don't want to cache the WAR file, so delete it" comment. Make sense to have the artifact upload just before.

Oliver Bertuch (Aug 17 2023 at 11:29):

... if you want to upload before you know integration / E2E test results

Philip Durbin 🚀 (Aug 17 2023 at 11:29):

well... :sweat_smile:

Philip Durbin 🚀 (Aug 17 2023 at 11:30):

maybe we upload two versions: tested and untested :grimacing:

Philip Durbin 🚀 (Aug 17 2023 at 11:30):

I'm confused though. The war is in ~/.m2/repository/edu/harvard/iq/dataverse rather than target?

Oliver Bertuch (Aug 17 2023 at 11:30):

It probably is in both

Oliver Bertuch (Aug 17 2023 at 11:31):

The install step will copy it from target to .m2

Philip Durbin 🚀 (Aug 17 2023 at 11:34):

Ok, cool. Now I'm wondering to myself why I always type mvn package instead of mvn install. Both seem to create the war file.

Oliver Bertuch (Aug 17 2023 at 11:35):

Please be aware that the CI command always uses the parent module

Oliver Bertuch (Aug 17 2023 at 11:35):

This way, the SPI package (or any other future modules we might add) is in the reactor

Oliver Bertuch (Aug 17 2023 at 11:36):

We must use the install target for Maven, as package would invoke that target, but then the submodules would not be around when the main app is being built

Philip Durbin 🚀 (Aug 17 2023 at 11:36):

@Oliver Bertuch do you feel like making a PR into https://github.com/IQSS/dataverse/pull/9764 to push the war file to GitHub Artifacts (or whatever it's called).

Oliver Bertuch (Aug 17 2023 at 11:37):

This is not critical as long as the SPI module did not change, as it can be pulled from Maven Central. But then the workflow breaks for PRs to the SPI module

Philip Durbin 🚀 (Aug 17 2023 at 11:44):

Maybe we could prototype the war upload with this tiny app: https://github.com/IQSS/dataverse-people

Philip Durbin 🚀 (Aug 17 2023 at 11:45):

Or we could go straight to the Java 17 branch :big_smile:

Oliver Bertuch (Aug 17 2023 at 11:45):

:+1: J17

Philip Durbin 🚀 (Aug 17 2023 at 11:45):

Cool. Do you want to make a PR?

Oliver Bertuch (Aug 17 2023 at 11:45):

Oh wait

Oliver Bertuch (Aug 17 2023 at 11:45):

PR or push?

Oliver Bertuch (Aug 17 2023 at 11:46):

PR onto J17 branch?

Philip Durbin 🚀 (Aug 17 2023 at 11:46):

I think I'd like to look at it. It's already in QA. So PR please if you don't mind.

Oliver Bertuch (Aug 17 2023 at 11:46):

So PR for develop, aye?

Philip Durbin 🚀 (Aug 17 2023 at 11:46):

Oh, I was thinking PR into the Java 17 PR.

Oliver Bertuch (Aug 17 2023 at 11:47):

But it's in QA?

Oliver Bertuch (Aug 17 2023 at 11:47):

Is that OK to add?

Philip Durbin 🚀 (Aug 17 2023 at 11:47):

What's driving this is that we'd like to be able to point QA at a Java 17 war artifact.

Philip Durbin 🚀 (Aug 17 2023 at 11:47):

Well, if it's a PR. I'll look at it and communicate with QA about merge it or not. The timing, basically.

Oliver Bertuch (Aug 17 2023 at 11:48):

Roger roger

Philip Durbin 🚀 (Aug 17 2023 at 11:48):

Phew. Sorry so complicated.

Philip Durbin 🚀 (Aug 17 2023 at 11:48):

If it was earlier (PR still in progress), I'd say just push directly to the branch.

Oliver Bertuch (Aug 17 2023 at 11:48):

Do you want an issue first?

Philip Durbin 🚀 (Aug 17 2023 at 11:51):

Oh! If you want. Might be nice for tracking.

Philip Durbin 🚀 (Aug 17 2023 at 11:51):

Maybe this will be the start of cutting releases with GitHub Actions. :stuck_out_tongue_wink:

Don Sizemore (Aug 17 2023 at 11:52):

@Oliver Bertuch I've always been told to do a package so I've always done a package - should I update all the Jenkins jobs (and Ansible, and whatever else) to install instead?

Oliver Bertuch (Aug 17 2023 at 11:52):

Retention days?

Don Sizemore (Aug 17 2023 at 11:53):

Oliver Bertuch said:

Retention days?

1, or 2, or 7 or whatever. This is for Kevin's benefit.

Oliver Bertuch (Aug 17 2023 at 11:53):

@Don Sizemore that depends on what you are trying to do. If you want to properly build the SPI along with the rest, see that job for the command to use