Stream: dev

Topic: ✔ UNF 6.0 breaks builds


view this post on Zulip Oliver Bertuch (Sep 14 2023 at 14:32):

Hi @luddaniel and thanks for your mail via the google group. https://groups.google.com/g/dataverse-community/c/YQgMEpSX360

view this post on Zulip Oliver Bertuch (Sep 14 2023 at 14:32):

And thanks for hanging with the containers nerd earlier today - as discussed there, let's release a 6.0.1 with JDK8+ compatibility to restore working builds for people.

view this post on Zulip Oliver Bertuch (Sep 14 2023 at 14:33):

I just pushed a little sth. to make the CI release such artifacts...

view this post on Zulip Oliver Bertuch (Sep 14 2023 at 14:33):

Could you check if it works for you by using the 6.0.1-SNAPSHOT on Maven Central?

view this post on Zulip Oliver Bertuch (Sep 14 2023 at 14:34):

You might need to enable the snapshot repos though, depending on your forks status

view this post on Zulip Oliver Bertuch (Sep 14 2023 at 14:34):

Please let me know if this works for y'all, then I'm happy to tag and push a 6.0.1 release

view this post on Zulip Oliver Bertuch (Sep 14 2023 at 14:34):

Pretty sure @Philip Durbin would do the honors of informing people... :stuck_out_tongue:

view this post on Zulip luddaniel (Sep 14 2023 at 14:35):

I just tested https://s01.oss.sonatype.org/content/repositories/snapshots/org/dataverse/unf/6.0.1-SNAPSHOT/unf-6.0.1-20230914.142442-1.jar and it seems to work :)

view this post on Zulip luddaniel (Sep 14 2023 at 14:36):

cp unf-6.0.1-20230914.142442-1.jar /home/ludan/.m2/repository/org/dataverse/unf/6.0/unf-6.0.jar
mvn package BUILD SUCCESS with Java 11

view this post on Zulip Oliver Bertuch (Sep 14 2023 at 14:38):

Haha that's another way of using a snapshot :grinning_face_with_smiling_eyes:

view this post on Zulip luddaniel (Sep 14 2023 at 14:38):

<dependency>
<groupId>org.dataverse</groupId>
<artifactId>unf</artifactId>
<version>6.0.1-SNAPSHOT</version>
</dependency>

[ERROR] Failed to execute goal on project dataverse: Could not resolve dependencies for project edu.harvard.iq:dataverse:war:5.14: Could not find artifact org.dataverse:unf:jar:6.0.1-SNAPSHOT in central-repo (https://repo1.maven.org/maven2) -> [Help 1]

view this post on Zulip luddaniel (Sep 14 2023 at 14:39):

hum looks bad, what do you think ?

view this post on Zulip Oliver Bertuch (Sep 14 2023 at 14:39):

Yeah... That's what I expected to see

view this post on Zulip Oliver Bertuch (Sep 14 2023 at 14:39):

Did you enable the snapshot repo?

view this post on Zulip luddaniel (Sep 14 2023 at 14:39):

mvn config ?

view this post on Zulip Oliver Bertuch (Sep 14 2023 at 14:40):

Here's how this looks like in DV 6.0:
https://github.com/IQSS/dataverse/blob/92404af076e51dd3799b23f00b1d45bf56885607/modules/dataverse-parent/pom.xml#L417-L438

view this post on Zulip Oliver Bertuch (Sep 14 2023 at 14:41):

Depending on the DV version you are using in your fork, you might already have these entries in the parent module, but probably commented out.

view this post on Zulip luddaniel (Sep 14 2023 at 14:43):

thanks

view this post on Zulip Oliver Bertuch (Sep 14 2023 at 14:44):

Does it work yet?

view this post on Zulip Oliver Bertuch (Sep 14 2023 at 14:44):

@Philip Durbin wanna practice releasing one more time?

view this post on Zulip luddaniel (Sep 14 2023 at 14:44):

Downloaded from oss-sonatype: https://s01.oss.sonatype.org/content/repositories/snapshots/org/dataverse/unf/6.0.1-SNAPSHOT/unf-6.0.1-20230914.142442-1.jar (51 kB at 124 kB/s)

BUILD SUCCESS :)

view this post on Zulip Oliver Bertuch (Sep 14 2023 at 14:45):

Hrhr

view this post on Zulip Oliver Bertuch (Sep 14 2023 at 14:45):

Glad to hear that!

view this post on Zulip luddaniel (Sep 14 2023 at 14:46):

what a maven storm machine ^^

view this post on Zulip Oliver Bertuch (Sep 14 2023 at 14:46):

@Philip Durbin it's all yours if you would like to do the honors

view this post on Zulip Oliver Bertuch (Sep 14 2023 at 14:50):

I just posted this to the group: https://groups.google.com/g/dataverse-community/c/YQgMEpSX360/m/iAOyZF38AQAJ

view this post on Zulip Oliver Bertuch (Sep 14 2023 at 14:53):

I suspect @Philip Durbin to be scoffing some lunch and going to standup, then frontend meeting. So might take a while until he responds back if he wants to actually cut the release. Please check back tomorrow (as our workday is coming to an end when living in CEST)

view this post on Zulip luddaniel (Sep 14 2023 at 14:54):

that's fast enough for me, I'm not in a rush. Thank you guys anyway ;)

view this post on Zulip Oliver Bertuch (Sep 14 2023 at 14:56):

No worries, anytime

view this post on Zulip Philip Durbin 🚀 (Sep 14 2023 at 16:34):

@Oliver Bertuch ah, so you didn't make a pull request. Just pushed to master? Nothing for me to review? /me puts his feet up :big_smile:

view this post on Zulip Oliver Bertuch (Sep 14 2023 at 16:34):

Nope, nothing to Review. Sorry but without pushing to Master no snapshot

view this post on Zulip Oliver Bertuch (Sep 14 2023 at 16:35):

Worst case scenario would be Syntax error in workflow file

view this post on Zulip Oliver Bertuch (Sep 14 2023 at 16:35):

And it worked! Just like that! (Trivial change though)

view this post on Zulip Philip Durbin 🚀 (Sep 14 2023 at 17:29):

And you did it all it a single commit with no mistakes?!? :robot: https://github.com/IQSS/UNF/commit/dfa4be3c457d886b265d4e0dcac42af8fc8a6339

view this post on Zulip Oliver Bertuch (Sep 19 2023 at 11:43):

@Philip Durbin - @Péter Pallinger is asking for a release of 6.0.1. Do you still want to do the honors or should I?

view this post on Zulip Oliver Bertuch (Sep 19 2023 at 11:44):

@Péter Pallinger would you be able to give the snapshot a try? Just want to make sure it really works before putting out a 6.0.1. Thx!

view this post on Zulip Philip Durbin 🚀 (Sep 19 2023 at 11:47):

Oh! I should do the release. It would be good practice for me.

view this post on Zulip Oliver Bertuch (Sep 19 2023 at 12:03):

Please go ahead! :smiling_face:

view this post on Zulip Philip Durbin 🚀 (Sep 19 2023 at 12:25):

Done! https://github.com/IQSS/UNF/issues/5#issuecomment-1725411589

view this post on Zulip Oliver Bertuch (Sep 19 2023 at 12:42):

Done! https://repo1.maven.org/maven2/org/dataverse/unf/6.0.1/

view this post on Zulip Oliver Bertuch (Sep 19 2023 at 12:44):

@Péter Pallinger we'd be glad to get feedback if 6.0.1 works for you! Out now! Let us know!

view this post on Zulip Péter Pallinger (Sep 19 2023 at 13:29):

@Oliver Bertuch Dataverse 5.13 build works with UNF 6.0.1 , but it needs changing the pom.xml to explicitly use 6.0.1.
This is not a big problem for us, as we use a fork anyway, but anyone trying to install the standard 5.13 tag will still have problems.

view this post on Zulip Oliver Bertuch (Sep 19 2023 at 13:30):

Great that it works for you! It is indeed intended to help people running forks, so can change the version number.

view this post on Zulip Oliver Bertuch (Sep 19 2023 at 13:30):

There is no way to take back that 6.0 release anyhow

view this post on Zulip Péter Pallinger (Sep 19 2023 at 13:31):

I can think of use cases where it is still problematic, so there should at least be a warning somewhere...

view this post on Zulip Oliver Bertuch (Sep 19 2023 at 13:31):

Also: anyone not building their own version but using the standard releases (WAR file) won't be bothered with this

view this post on Zulip Péter Pallinger (Sep 19 2023 at 13:32):

ok, that is most probably true...

view this post on Zulip Oliver Bertuch (Sep 19 2023 at 13:32):

Not just "most probably" :wink: The WAR file contains all Java dependencies, nothing will be downloaded from anywhere.

view this post on Zulip Oliver Bertuch (Sep 19 2023 at 13:32):

Not as long as you won't build your own release package

view this post on Zulip Péter Pallinger (Sep 19 2023 at 13:33):

I mean the war route is OK, but there is a tiny chance that someone tries to build the stock version for whatever reason :)

view this post on Zulip Oliver Bertuch (Sep 19 2023 at 13:34):

Oh yeah well... :shrug: Sounds like they'll need to update this tiny thing then...

view this post on Zulip Péter Pallinger (Sep 19 2023 at 13:34):

For example, I did just that when I realized my fork does not work, and tried to check whether we did something wrong, or the build environment was somewhow bad on a new VM

view this post on Zulip Philip Durbin 🚀 (Sep 19 2023 at 13:35):

How important is it that we switch to 6.0.1 in the develop branch?

view this post on Zulip Oliver Bertuch (Sep 19 2023 at 13:36):

Sure. No way around that. It was a mistake to not include backward compatibility, but what's done is done. We cannot make Maven present some warning message. There is a thread on the mailing list about this and people do find us here. If you have a good idea where else we can add a warning, please let us know @Péter Pallinger :smile:

view this post on Zulip Oliver Bertuch (Sep 19 2023 at 13:36):

Philip Durbin said:

How important is it that we switch to 6.0.1 in the develop branch?

Technically not at all.

view this post on Zulip Philip Durbin 🚀 (Sep 19 2023 at 13:37):

ok, thanks

view this post on Zulip Philip Durbin 🚀 (Sep 19 2023 at 13:37):

@Péter Pallinger here's the UNF thread, started by @luddaniel - https://groups.google.com/g/dataverse-community/c/YQgMEpSX360/m/GUqvuJDzAQAJ

view this post on Zulip Philip Durbin 🚀 (Sep 19 2023 at 13:38):

@Oliver Bertuch I accepted the default for the next snapshot: 6.0.2. Is that what you would have done? I guess the other option is 6.1.

view this post on Zulip Oliver Bertuch (Sep 19 2023 at 13:38):

Fine with me

view this post on Zulip Oliver Bertuch (Sep 19 2023 at 13:39):

That lib does not have a release policy

view this post on Zulip Oliver Bertuch (Sep 19 2023 at 18:39):

Guess we can close this topic as resolved.

view this post on Zulip Notification Bot (Sep 19 2023 at 18:39):

Oliver Bertuch has marked this topic as resolved.


Last updated: Nov 01 2025 at 14:11 UTC