Oliver Bertuch (Oct 03 2023 at 09:18): Oliver Bertuch (Oct 03 2023 at 09:18):@Don Sizemore question for you wrt https://github.com/IQSS/dataverse/pull/9273...
I change the output of the unit tests to be located somewhere else in https://github.com/IQSS/dataverse/blob/379022ce5bfde3fefd204a9da7ca9d33ea7ed94d/pom.xml#L746.
Now I'm wondering which file is which at https://github.com/GlobalDataverseCommunityConsortium/dataverse-ansible/blob/7d8a425a8e1293717f31c2fd6d01c1d1801cf625/tasks/jacoco-generate_report.yml#L19...
Is the domain1/config/jacoco.exec the data from the unit tests ran before or is it target/jacoco.exec?
Don Sizemore (Oct 03 2023 at 11:11):Oliver Bertuch said:
Don Sizemore question for you wrt https://github.com/IQSS/dataverse/pull/9273...
I change the output of the unit tests to be located somewhere else in https://github.com/IQSS/dataverse/blob/379022ce5bfde3fefd204a9da7ca9d33ea7ed94d/pom.xml#L746.
Now I'm wondering which file is which at https://github.com/GlobalDataverseCommunityConsortium/dataverse-ansible/blob/7d8a425a8e1293717f31c2fd6d01c1d1801cf625/tasks/jacoco-generate_report.yml#L19...Is the
domain1/config/jacoco.execthe data from the unit tests ran before or is ittarget/jacoco.exec?
IIRC the one under target/ results from unit tests; config/ is written post-IT run.
Philip Durbin 🚀 (Oct 03 2023 at 13:30):Question: what if we test and merge this PR and adjust the paths in Ansible/Jenkins afterward?
Philip Durbin 🚀 (Oct 03 2023 at 14:12):I just created an issue: https://github.com/GlobalDataverseCommunityConsortium/dataverse-ansible/issues/325
Philip Durbin 🚀 (Oct 03 2023 at 14:15):And a pull request: https://github.com/GlobalDataverseCommunityConsortium/dataverse-ansible/pull/326
Philip Durbin 🚀 (Oct 03 2023 at 14:16):@Don Sizemore would you be able to help me set up a new Jenkins job to test that branch? I can probably do it but I'm not sure which job to copy.
Philip Durbin 🚀 (Oct 03 2023 at 14:27):Ok, I copied develop, tweaked it, and kicked off a run. Wish me luck! https://jenkins.dataverse.org/job/IQSS-dataverse-9273-oidc/1/
Philip Durbin 🚀 (Oct 03 2023 at 14:44):This feels like more than a 3, by the way. :grinning:
Oliver Bertuch (Oct 03 2023 at 15:13):10?
Oliver Bertuch (Oct 03 2023 at 15:13):Thx for the PR!
Philip Durbin 🚀 (Oct 03 2023 at 15:17):Yeah, a 10, I guess.
Philip Durbin 🚀 (Oct 03 2023 at 15:17):Good news: API tests passed on Jenkins.
Philip Durbin 🚀 (Oct 03 2023 at 15:18):Bad news: something in the Jenkins job is still failing.
Philip Durbin 🚀 (Oct 03 2023 at 15:18):Please see attached: fail.txt
Don Sizemore (Oct 03 2023 at 17:38):Philip Durbin said:
Don Sizemore would you be able to help me set up a new Jenkins job to test that branch? I can probably do it but I'm not sure which job to copy.
absolutely! we probably just want to grab IQSS-Dataverse-Develop and modify it.
Philip Durbin 🚀 (Oct 03 2023 at 18:09):Yeah, that's the one I ended up copying or cloning or whatever.
Philip Durbin 🚀 (Oct 03 2023 at 18:10):It got pretty far. API tests passed. But at the end there was a weird failure. fail.txt above ^^
Philip Durbin 🚀 (Oct 03 2023 at 18:10):Any idea what's going on?
Philip Durbin 🚀 (Oct 03 2023 at 21:08):Bah, even after https://github.com/GlobalDataverseCommunityConsortium/dataverse-ansible/pull/326/commits/d83118388dab48353be16aac7c3aa524e0fd1283 it failed with the same error: https://jenkins.dataverse.org/job/IQSS-dataverse-9273-oidc/2/consoleFull
Philip Durbin 🚀 (Oct 04 2023 at 13:40):Any ideas? :sweat_smile:
Philip Durbin 🚀 (Oct 04 2023 at 13:52):#9273 was merged! Now what?
Philip Durbin 🚀 (Oct 04 2023 at 16:02):I brought it up at standup. I created a note that can be converted into an issue.
Philip Durbin 🚀 (Oct 04 2023 at 16:02):We could simply disable whatever Jenkins is doing, of course. Hopefully temporarily. :sweat_smile:
Oliver Bertuch (Oct 04 2023 at 18:18):So, should we try to tackle this again?
Oliver Bertuch (Oct 04 2023 at 18:23):I do have a few ideas regarding paths for the Jenkins plugins @Don Sizemore ...
Philip Durbin 🚀 (Oct 04 2023 at 18:24):Yes, please!
Philip Durbin 🚀 (Oct 04 2023 at 18:24):We can't leave it broken.
Philip Durbin 🚀 (Oct 04 2023 at 18:25):On a related note, we could maybe try to do the equivalent in the API runner. If nothing else to make sure we have it working in that environment.
Oliver Bertuch (Oct 04 2023 at 18:27):You wanted a second opinion, so maybe let the Jenkins surgeon do it's magic and the Github API runner its own?
Philip Durbin 🚀 (Oct 04 2023 at 18:28):Ha, well, it's the same three people so we'll help each other out. :grinning:
Don Sizemore (Oct 04 2023 at 18:38):Oliver Bertuch said:
I do have a few ideas regarding paths for the Jenkins plugins Don Sizemore ...
tell me what to do and I'll do it?
Oliver Bertuch (Oct 04 2023 at 18:41):Should we do a quick Zoomzoom @Don Sizemore ?
Philip Durbin 🚀 (Oct 04 2023 at 18:43):I'm happy to Zoom but I need a room.
Oliver Bertuch (Oct 04 2023 at 18:43):https://fz-juelich-de.zoom.us/j/61671309203?pwd=VmFIN2t2dEVtOTN3aTUyVWcvSDdzQT09
Oliver Bertuch (Oct 04 2023 at 20:02):@Don Sizemore @Philip Durbin I'm back. Did you muddle through?
Philip Durbin 🚀 (Oct 04 2023 at 20:29):We hacked on https://github.com/GlobalDataverseCommunityConsortium/dataverse-ansible/pull/326 a bit more, merged it, and kicked off https://jenkins.dataverse.org/job/IQSS-dataverse-develop/1501/ but it failed with an API test error. So not a good test, unfortunately.
Philip Durbin 🚀 (Oct 05 2023 at 15:02):Fixed! I think! https://jenkins.dataverse.org/job/IQSS-dataverse-develop/1502/ passed anyway. Green. API tests passed.
Notification Bot (Oct 05 2023 at 18:00):Philip Durbin has marked this topic as resolved.
Last updated: Nov 01 2025 at 14:11 UTC