Philip Durbin 🚀 (Jun 12 2023 at 20:37): Philip Durbin 🚀 (Jun 12 2023 at 20:37):Are there any 5.14 tasks you'd like to hack on?
Oliver Bertuch (Jun 12 2023 at 20:37):Ha! Quid pro quo?
Oliver Bertuch (Jun 12 2023 at 20:41):What would you like me to hack on?
Philip Durbin 🚀 (Jun 12 2023 at 20:43):https://github.com/IQSS/dataverse/issues/9633 I guess?!?
Philip Durbin 🚀 (Jun 12 2023 at 20:45):It's the only thing at https://github.com/IQSS/dataverse/milestones/5.14 that makes sense, really.
Philip Durbin 🚀 (Jun 12 2023 at 20:45):The rest is in progress or whatever.
Philip Durbin 🚀 (Jun 12 2023 at 20:46):Unless you'd like to review something.
Oliver Bertuch (Jun 12 2023 at 20:46):OK what would you like me to do - just a simple fix or also add some test to load the TSV and try to add the dataset?
Philip Durbin 🚀 (Jun 12 2023 at 20:47):You shouldn't need to load any TSVs but you will need to enable the default blocks.
Philip Durbin 🚀 (Jun 12 2023 at 20:47):And then add an API test for dataset-create-new-all-default-fields.json please.
Oliver Bertuch (Jun 12 2023 at 20:47):Ah beloved API tests
Oliver Bertuch (Jun 12 2023 at 20:48):Some preferred test class for this? DatasetIT?
Philip Durbin 🚀 (Jun 12 2023 at 20:48):You can set blocks like this:
UtilIT.setMetadataBlocks(dataverseAlias, Json.createArrayBuilder().add("citation").add("astrophysics"), apiToken);
Oliver Bertuch (Jun 12 2023 at 20:49):Tempted to also convert that testclass into JUnit5 while in there, so we can make use of more interesting things down the road
Philip Durbin 🚀 (Jun 12 2023 at 20:49):You're also welcome to create a fresh testclass.
Oliver Bertuch (Jun 12 2023 at 20:50):Orly?
Philip Durbin 🚀 (Jun 12 2023 at 20:50):As long as you add it to the list in test/integration-tests.txt
Oliver Bertuch (Jun 12 2023 at 20:50):Yikes.
Philip Durbin 🚀 (Jun 12 2023 at 20:51):Yes, plenty of tech debt.
Oliver Bertuch (Jun 12 2023 at 20:51):Who needs tags for selecting tests when we can have a text file :-D
Philip Durbin 🚀 (Jun 12 2023 at 20:51):T-T
Oliver Bertuch (Jun 12 2023 at 20:55):There already is DatasetsIT.testExport() using scripts/api/data/dataset-create-new.json so I'm just going to add a new test there
Oliver Bertuch (Jun 12 2023 at 20:56):Oh wait we have a MetadataBlocksIT! That seems like an even better fit
Philip Durbin 🚀 (Jun 12 2023 at 20:57):Go go go
Oliver Bertuch (Jun 12 2023 at 22:19):https://github.com/IQSS/dataverse/pull/9636
Philip Durbin 🚀 (Jun 12 2023 at 22:26):Looks good! Just waiting for the tests to pass.
Philip Durbin 🚀 (Jun 12 2023 at 22:26):Thanks!
Oliver Bertuch (Jun 12 2023 at 22:26):You're welcome!
Oliver Bertuch (Jun 12 2023 at 22:27):Test (not tests) passed on localhost. Obviously using dockerized test instance :-D (And failed before applying the fix... TDD for the win)
Philip Durbin 🚀 (Jun 12 2023 at 22:28):I figured but you know. :happy: Worth the wait.
Oliver Bertuch (Jun 12 2023 at 22:29):Also found another error with a wrong CV term
Oliver Bertuch (Jun 12 2023 at 22:29):I did not add blocks - suppose they are installed by default...
Oliver Bertuch (Jun 12 2023 at 22:30):Haha Jenkins failed
Oliver Bertuch (Jun 12 2023 at 22:30):Let me guess... Dead S3
Oliver Bertuch (Jun 12 2023 at 22:31):Yupp.
TASK [dataverse : download payara zip] *********
fatal: [localhost]: FAILED! => {"changed": false, "dest": "/tmp/payara.zip", "elapsed": 0, "msg": "Request failed", "response": "HTTP Error 404: Not Found", "status_code": 404, "url": "https://s3-eu-west-1.amazonaws.com/payara.fish/Payara+Downloads/5.2022.3/payara-5.2022.3.zip"}
Oliver Bertuch (Jun 12 2023 at 22:33):@Don Sizemore can we help? Nevermind. He said "I can update the role defaults tomorrow" on dv-tech.
Philip Durbin 🚀 (Jun 12 2023 at 22:45):Woof. Good to know the Payara thing is breaking Jenkins. Thanks.
Don Sizemore (Jun 13 2023 at 11:15):Philip Durbin said:
Woof. Good to know the Payara thing is breaking Jenkins. Thanks.
This is fixed: https://jenkins.dataverse.org/job/IQSS-dataverse-develop/1368/console
Philip Durbin 🚀 (Jun 13 2023 at 11:35):@Don Sizemore thanks!
Philip Durbin 🚀 (Jun 13 2023 at 11:36):@Oliver Bertuch I'm running another build: https://jenkins.dataverse.org/job/IQSS-Dataverse-Develop-PR/job/PR-9636/2/
Oliver Bertuch (Jun 13 2023 at 11:50):Go go go!
Oliver Bertuch (Jun 13 2023 at 12:21):Suppose this is not on me. https://jenkins.dataverse.org/job/IQSS-Dataverse-Develop-PR/job/PR-9636/lastFailedBuild/testReport/edu.harvard.iq.dataverse.api/FilesIT/testGetFileInfo/
Oliver Bertuch (Jun 13 2023 at 12:29):
Philip Durbin 🚀 (Jun 13 2023 at 12:29):Yes, thanks. Left a comment and rerunning.
Philip Durbin 🚀 (Jun 13 2023 at 20:30):Any hacking tonight?
Philip Durbin 🚀 (Jun 16 2023 at 20:28):I just noticed you can't publish the dataset added in this PR: https://github.com/IQSS/dataverse/pull/9636#issuecomment-1595271965
Philip Durbin 🚀 (Jun 20 2023 at 15:36):@Oliver Bertuch what do you think? Should I create a new issue?
Oliver Bertuch (Jun 20 2023 at 16:50):Probably. And maybe we should add to testing to publish it, too.
Philip Durbin 🚀 (Jun 20 2023 at 17:54):Leonid just stopped by to chat about it.
Philip Durbin 🚀 (Jun 20 2023 at 18:38):On his non-Docker setup his dataset gets a license. I wonder what the difference is.
Philip Durbin 🚀 (Jun 20 2023 at 18:44):False alarm. Something weird in my environment, maybe: https://github.com/IQSS/dataverse/pull/9636#issuecomment-1599327764
Philip Durbin 🚀 (Aug 11 2023 at 17:50):5.14 is out! https://github.com/IQSS/dataverse/releases/tag/v5.14
Notification Bot (Aug 11 2023 at 17:50):Philip Durbin has marked this topic as resolved.
Last updated: Nov 01 2025 at 14:11 UTC