✔ /push-images #9575 · containers

Stream: containers

Topic: ✔ /push-images #9575

Philip Durbin 🚀 (May 04 2023 at 16:35):

Should we go ahead and create a note/draft (future issue) for the /push-images idea?

For the uninitiated, we discussed this extensively during last week's meeting and gave an update just now at this week's meeting.

Philip Durbin 🚀 (May 05 2023 at 00:02):

I see that :thumbs_up:

I created a draft at https://github.com/orgs/IQSS/projects/34/views/17

Philip Durbin 🚀 (May 05 2023 at 12:43):

@Oliver Bertuch thanks for creating the issue: Enable PR-based app images from forks #9575

Oliver Bertuch (May 05 2023 at 13:19):

Sure thing. Left office early today, couldn't make myself code

Oliver Bertuch (May 05 2023 at 13:19):

Might resume later

Oliver Bertuch (May 05 2023 at 13:20):

Currently bringing out leveling compound. Working with hands and soul is sometimes the distraction one needs

Oliver Bertuch (May 08 2023 at 06:18):

Alright lads, here we go...

Oliver Bertuch (May 08 2023 at 06:18):

Plz take a look at https://github.com/IQSS/dataverse/pull/9576 and https://github.com/IQSS/dataverse/pull/9577

Oliver Bertuch (May 08 2023 at 06:19):

As you can see, depening on the origin of a pull request (have secrets access or don't), all the pushy things are either skipped or executed

Oliver Bertuch (May 08 2023 at 06:19):

So this part works, PRs from IQSS itself won't need comments, staying out of the way of non-containercuted folks

Oliver Bertuch (May 08 2023 at 06:20):

Will now add the "comment to push" part as well, but that can only be seen in action after merging it to base branch

Oliver Bertuch (May 08 2023 at 07:04):

The PR comment about the preview image is now a bit easier to use: by wrapping the image name in a code block, we have a nice copy button. That could be helpful when using the image name :wink:

Oliver Bertuch (May 08 2023 at 07:04):

See https://github.com/IQSS/dataverse/pull/9577#issuecomment-1537837850 for an example

Oliver Bertuch (May 08 2023 at 08:28):

Alright, I got the PR Command thing in my PR

Oliver Bertuch (May 08 2023 at 08:28):

@Philip Durbin how do we go ahead with this?

Philip Durbin 🚀 (May 08 2023 at 11:09):

@Oliver Bertuch PR #9576 looks good to me. Like you said, we can't really test it until it has been merged. I'm happy to go ahead and do that. Are you ready?

Oliver Bertuch (May 08 2023 at 11:12):

Yes and no. Do you want docs?

Philip Durbin 🚀 (May 08 2023 at 11:14):

Well, we have an issue for docs, we could add them there: https://dataverse.zulipchat.com/#narrow/stream/375812-containers/topic/docs.20for.20milestone.20A.20.239540

Oliver Bertuch (May 08 2023 at 11:14):

Why does it sound like we are procrastinating on docs :smile:

Philip Durbin 🚀 (May 08 2023 at 11:16):

Like I said, if you start the branch, I'll add commits. :happy:

Oliver Bertuch (May 08 2023 at 11:17):

OK ok but do we want docs added in this branch?

Oliver Bertuch (May 08 2023 at 11:17):

What would be a good place to document the comment command?

Oliver Bertuch (May 08 2023 at 11:17):

Dev guides?

Oliver Bertuch (May 08 2023 at 11:18):

Do we have sth on CI in there already?

Oliver Bertuch (May 08 2023 at 11:18):

We might want to add more bits down the road about API tests etc

Philip Durbin 🚀 (May 08 2023 at 11:18):

I'd say somewhere near https://guides.dataverse.org/en/5.13/developers/version-control.html#how-to-make-a-pull-request

Oliver Bertuch (May 08 2023 at 11:18):

And a potential gh action

Philip Durbin 🚀 (May 08 2023 at 11:19):

We could say more than just this:

"Make a pull request to get approval to merge your changes into the develop branch. Note that once a pull request is created, we’ll remove the corresponding issue from our kanban board so that we’re only tracking one card."